-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add web-infra onboarding docs #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: flakey5 <[email protected]>
Tasks prefixed by `Member:` are for the new member to complete. | ||
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. | ||
|
||
- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly think this might be better as an issue template and this doc just links to it, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Member can do this in their "Add xyz to the list of MEMBERS" PR, and the team will check off each task before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps make an ONBOARDING.md
, with a # @nodejs/web-infra
section?
Tasks prefixed by `Member:` are for the new member to complete. | ||
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we can just say "A web admin should ...", "The onboardee should ...". in each task
Tasks prefixed by `Member:` are for the new member to complete. | ||
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. | ||
|
||
- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Member can do this in their "Add xyz to the list of MEMBERS" PR, and the team will check off each task before merging?
|
||
- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. | ||
- Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. | ||
- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Node.js Organization requires 2FA, so this isn't something we need to explicitly say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to state this -- the org requires 2FA, this is a recommendation specifically to use a physical factor, which AIUI is not enforced at the org level.
- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. | ||
- Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. | ||
- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. | ||
- [ ] Web Admin: Recommend member sign their Git commits if not already doing so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the "Web Admin: Recommend" aren't really needed, and should be put as a separate section "# Recommendations for New Members" of this file?
@flakey5 I also believe we could document our Slack channels on the onboarding doc and what they server for. (there's the website one, alerts one, i18n one for website, and others I gues?) |
OOC, why is the PR blocked? |
@flakey5 I forgot, we also have this list for Crowdin: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L175 Can you also add this to the onboarding docs, we also need the current remaining members of web-infra added there! |
Per the PR description,
|
Co-authored-by: Aviv Keller <[email protected]> Co-authored-by: Matt Cowley <[email protected]>
Re #5
Note: blocked until nodejs/admin#984 goes through since this mentions the
web-admins
team.