Skip to content

Add web-infra onboarding docs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Jul 13, 2025

Re #5

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

@flakey5 flakey5 requested a review from a team as a code owner July 13, 2025 18:12
Tasks prefixed by `Member:` are for the new member to complete.
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete.

- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly think this might be better as an issue template and this doc just links to it, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Member can do this in their "Add xyz to the list of MEMBERS" PR, and the team will check off each task before merging?

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make an ONBOARDING.md, with a # @nodejs/web-infra section?

Comment on lines +9 to +10
Tasks prefixed by `Member:` are for the new member to complete.
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can just say "A web admin should ...", "The onboardee should ...". in each task

Tasks prefixed by `Member:` are for the new member to complete.
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete.

- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Member can do this in their "Add xyz to the list of MEMBERS" PR, and the team will check off each task before merging?


- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it.
- Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping.
- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js Organization requires 2FA, so this isn't something we need to explicitly say.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to state this -- the org requires 2FA, this is a recommendation specifically to use a physical factor, which AIUI is not enforced at the org level.

- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it.
- Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping.
- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases.
- [ ] Web Admin: Recommend member sign their Git commits if not already doing so.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the "Web Admin: Recommend" aren't really needed, and should be put as a separate section "# Recommendations for New Members" of this file?

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

@flakey5 I also believe we could document our Slack channels on the onboarding doc and what they server for. (there's the website one, alerts one, i18n one for website, and others I gues?)

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

OOC, why is the PR blocked?

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

@flakey5 I forgot, we also have this list for Crowdin: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L175

Can you also add this to the onboarding docs, we also need the current remaining members of web-infra added there!

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

@avivkeller
Copy link
Member

OOC, why is the PR blocked?

Per the PR description,

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Matt Cowley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants